From b08cc489df783815395d669d0f24a11ddc00217d Mon Sep 17 00:00:00 2001
From: Aleksandr Kurbatov <ak@geant.org>
Date: Tue, 26 Nov 2024 15:58:35 +0000
Subject: [PATCH] Update test_validate_router to include P and PE roles
---
test/workflows/router/test_validate_router.py | 20 +++++++++----------
1 file changed, 9 insertions(+), 11 deletions(-)
diff --git a/test/workflows/router/test_validate_router.py b/test/workflows/router/test_validate_router.py
index 54af04f9..1b2e371c 100644
--- a/test/workflows/router/test_validate_router.py
+++ b/test/workflows/router/test_validate_router.py
@@ -32,14 +32,15 @@ def test_validate_nokia_router_success(
mock_find_host_by_fqdn,
router_subscription_factory,
faker,
- data_config_filename,
- geant_partner,
router_state,
+ router_role,
):
mock_validate_librenms_device.return_value = None
+ router_subscription_factory(router_role=RouterRole.P)
+ router_subscription_factory(router_role=RouterRole.PE)
mock_kentik_client.return_value = MockedKentikClient
# Run workflow
- subscription_id = router_subscription_factory(status=router_state)
+ subscription_id = router_subscription_factory(status=router_state, router_role=router_role)
mock_fqdn = Router.from_subscription(subscription_id).router.router_fqdn
mock_v4 = faker.ipv4()
mock_find_host_by_fqdn.return_value = objects.HostRecord(
@@ -64,7 +65,9 @@ def test_validate_nokia_router_success(
state = extract_state(result)
subscription_id = state["subscription_id"]
- for _ in range(2):
+ lso_execution_count = 2 if router_role == RouterRole.P else 3
+
+ for _ in range(lso_execution_count):
result, step_log = assert_lso_success(result, process_stat, step_log)
assert_complete(result)
@@ -73,7 +76,7 @@ def test_validate_nokia_router_success(
subscription = Router.from_subscription(subscription_id)
assert subscription.status == router_state
- assert mock_execute_playbook.call_count == 2
+ assert mock_execute_playbook.call_count == lso_execution_count
assert mock_find_host_by_fqdn.call_count == 1
assert mock_get_device_by_name.call_count == 1
assert mock_validate_librenms_device.call_count == 1
@@ -81,12 +84,7 @@ def test_validate_nokia_router_success(
@pytest.mark.workflow()
-def test_validate_juniper_router_success(
- router_subscription_factory,
- faker,
- data_config_filename,
- geant_partner,
-):
+def test_validate_juniper_router_success(router_subscription_factory):
# Run workflow
subscription_id = router_subscription_factory(vendor=Vendor.JUNIPER)
--
GitLab