diff --git a/docs/vale/styles/Vocab/geant-jargon/accept.txt b/docs/vale/styles/Vocab/geant-jargon/accept.txt index f9dd1b51637ed1b2e93e61c6f3e97be90132b57c..8de3c79dbe36016d729a9916d363ddf0a00be386 100644 --- a/docs/vale/styles/Vocab/geant-jargon/accept.txt +++ b/docs/vale/styles/Vocab/geant-jargon/accept.txt @@ -1,7 +1,7 @@ GÉANT Automation Platform [GSO|gso] Vereniging -TERMINATE +[[T|t]ERMINATE|terminate] WFO Ansible [Dd]eprovision @@ -11,3 +11,4 @@ Dark_fiber [A|a]ddress [I|i]ptrunk [A|a]llocate +PHASE 1 diff --git a/gso/services/infoblox.py b/gso/services/infoblox.py index 8954036e0060d932f0f37e75e0a281d9f1c8a617..1dbc29ebdc2eb14f44f635711f1c58f50e998168 100644 --- a/gso/services/infoblox.py +++ b/gso/services/infoblox.py @@ -243,7 +243,7 @@ def find_host_by_ip( :type ip_addr: ipaddress.IPv4Address | ipaddress.IPv6Address """ conn, _ = _setup_connection() - if ip_addr.version == 4: # noqa: PLR2004, the 4 in IPv4 is well-known and not a "magic value". + if ip_addr.version == 4: # noqa: PLR2004, the 4 in IPv4 is well-known and not a "magic value." return objects.HostRecord.search( conn, ipv4addr=ip_addr, diff --git a/gso/utils/helpers.py b/gso/utils/helpers.py index d0df574570c85f4af0742b15d7e05b13dec25ba9..44cb8fe3eff1fa31037b39915af2617357bfb890 100644 --- a/gso/utils/helpers.py +++ b/gso/utils/helpers.py @@ -21,15 +21,19 @@ from gso.services.subscriptions import get_active_subscriptions_by_field_and_val class LAGMember(BaseModel): - """A :term:`LAG` member interface that consists of a name and description.""" + """A :term:`LAG` member interface that consists of a name and description. + + TODO: validate interface name + """ - # TODO: validate interface name interface_name: str interface_description: str def __hash__(self) -> int: - """Calculate the hash based on the interface name and description, so that uniqueness can be determined.""" - # TODO: check if this is still needed + """Calculate the hash based on the interface name and description, so that uniqueness can be determined. + + TODO: Check if this is still needed + """ return hash((self.interface_name, self.interface_description))