From aacb090c74c2078c0f32049852ae2ba94f88ea64 Mon Sep 17 00:00:00 2001 From: Mohammad Torkashvand <mohammad.torkashvand@geant.org> Date: Mon, 18 Mar 2024 14:57:46 +0100 Subject: [PATCH] resolve review notes --- gso/schema/__init__.py | 2 +- gso/services/partners.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gso/schema/__init__.py b/gso/schema/__init__.py index 1a41e97bc..20b21e2c5 100644 --- a/gso/schema/__init__.py +++ b/gso/schema/__init__.py @@ -1 +1 @@ -"""Partner schema module.""" +"""It is used to group the schema files together as a package.""" diff --git a/gso/services/partners.py b/gso/services/partners.py index ea2260284..f2080380e 100644 --- a/gso/services/partners.py +++ b/gso/services/partners.py @@ -47,6 +47,8 @@ def create_partner( except SQLAlchemyError: db.session.rollback() raise + finally: + db.session.close() def delete_partner_by_name(name: str) -> None: @@ -61,3 +63,5 @@ def delete_partner_by_name(name: str) -> None: except SQLAlchemyError: db.session.rollback() raise + finally: + db.session.close() -- GitLab