From 8c8d65ede855577c835be35f31d5274b8f869f86 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Mon, 30 Oct 2023 14:57:11 +0100
Subject: [PATCH] update ISIS modification workflow unit test

---
 .../iptrunk/test_modify_isis_metric.py        | 28 +++----------------
 1 file changed, 4 insertions(+), 24 deletions(-)

diff --git a/test/workflows/iptrunk/test_modify_isis_metric.py b/test/workflows/iptrunk/test_modify_isis_metric.py
index 521d6d27..a3a09802 100644
--- a/test/workflows/iptrunk/test_modify_isis_metric.py
+++ b/test/workflows/iptrunk/test_modify_isis_metric.py
@@ -3,14 +3,7 @@ from unittest.mock import patch
 import pytest
 
 from gso.products import Iptrunk
-from test.workflows import (
-    assert_complete,
-    assert_suspended,
-    extract_state,
-    resume_workflow,
-    run_workflow,
-    user_accept_and_assert_suspended,
-)
+from test.workflows import assert_complete, assert_pp_interaction_success, assert_suspended, extract_state, run_workflow
 
 
 @pytest.mark.workflow
@@ -30,22 +23,9 @@ def test_iptrunk_modify_isis_metric_success(
         {"tt_number": faker.tt_number(), "isis_metric": new_isis_metric},
     ]
     result, process_stat, step_log = run_workflow("modify_isis_metric", initial_iptrunk_data)
-    assert_suspended(result)
-
-    lso_return = {
-        "pp_run_results": {
-            "status": "ok",
-            "job_id": faker.uuid4(),
-            "output": "parsed_output",
-            "return_code": 0,
-        },
-        "confirm": "ACCEPTED",
-    }
-
-    result, step_log = user_accept_and_assert_suspended(process_stat, step_log, lso_return)
-    result, step_log = user_accept_and_assert_suspended(process_stat, step_log, [{}, {}])
-    result, step_log = user_accept_and_assert_suspended(process_stat, step_log, lso_return)
-    result, step_log = resume_workflow(process_stat, step_log, [{}, {}])
+
+    for _ in range(2):
+        result, step_log = assert_pp_interaction_success(result, process_stat, step_log)
 
     assert_complete(result)
 
-- 
GitLab