From 7ae46cdc218272693c2a9b6fa21e51c54e1227ed Mon Sep 17 00:00:00 2001
From: Mohammad Torkashvand <mohammad.torkashvand@geant.org>
Date: Mon, 29 Apr 2024 14:30:15 +0200
Subject: [PATCH] resolve review comments
---
...-04-30_1ec810b289c0_add_orchestrator_2_2_1_V2_migrations.py | 3 +--
gso/workflows/router/create_imported_router.py | 2 +-
gso/workflows/site/create_imported_site.py | 2 +-
3 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/gso/migrations/versions/2024-04-30_1ec810b289c0_add_orchestrator_2_2_1_V2_migrations.py b/gso/migrations/versions/2024-04-30_1ec810b289c0_add_orchestrator_2_2_1_V2_migrations.py
index a2acc5c1..0f4609b6 100644
--- a/gso/migrations/versions/2024-04-30_1ec810b289c0_add_orchestrator_2_2_1_V2_migrations.py
+++ b/gso/migrations/versions/2024-04-30_1ec810b289c0_add_orchestrator_2_2_1_V2_migrations.py
@@ -1,4 +1,4 @@
-"""remove subscription cancellation workflow.
+"""Add upstream migrations as a dependency.
Revision ID: 1ec810b289c0
Revises:
@@ -12,7 +12,6 @@ from orchestrator.migrations.helpers import create_workflow, delete_workflow
revision = '1ec810b289c0'
down_revision = '32cad119b7c4'
branch_labels = None
-# TODO: check it carefuly
depends_on = '048219045729' # in this revision, SURF has added a new columns to the workflow table like delted_at, so we need to add a dependency on the revision that added the columns to the workflow table.
diff --git a/gso/workflows/router/create_imported_router.py b/gso/workflows/router/create_imported_router.py
index d7c7e45c..a375965d 100644
--- a/gso/workflows/router/create_imported_router.py
+++ b/gso/workflows/router/create_imported_router.py
@@ -83,7 +83,7 @@ def initialize_subscription(
@workflow(
"Import router",
initial_input_form=initial_input_form_generator,
- target=Target.SYSTEM,
+ target=Target.CREATE,
)
def create_imported_router() -> StepList:
"""Import a router without provisioning it."""
diff --git a/gso/workflows/site/create_imported_site.py b/gso/workflows/site/create_imported_site.py
index 033893f0..5f3c328f 100644
--- a/gso/workflows/site/create_imported_site.py
+++ b/gso/workflows/site/create_imported_site.py
@@ -84,7 +84,7 @@ def initialize_subscription(
@workflow(
"Import Site",
- target=Target.SYSTEM,
+ target=Target.CREATE,
initial_input_form=generate_initial_input_form,
)
def create_imported_site() -> StepList:
--
GitLab