From 66bf227e8ca3c510e855bb65ba67d96b07b436df Mon Sep 17 00:00:00 2001
From: Neda Moeini <neda.moeini@geant.org>
Date: Thu, 5 Dec 2024 12:52:39 +0100
Subject: [PATCH] Update create EdgePort WF and rename generating GA and GS ids
function
---
gso/services/subscriptions.py | 4 ++--
gso/workflows/edge_port/create_edge_port.py | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gso/services/subscriptions.py b/gso/services/subscriptions.py
index e5b3c8e7..e6781244 100644
--- a/gso/services/subscriptions.py
+++ b/gso/services/subscriptions.py
@@ -333,7 +333,7 @@ def is_virtual_circuit_id_available(virtual_circuit_id: str) -> bool:
return is_resource_type_value_unique("virtual_circuit_id", virtual_circuit_id)
-def make_unique_gs_id() -> str:
+def generate_unique_gs_id() -> str:
"""Generate a unique GS ID using the gs_id_seq database sequence.
Returns:
@@ -351,7 +351,7 @@ def make_unique_gs_id() -> str:
return f"GS-{new_id}"
-def make_unique_ga_id() -> str:
+def generate_unique_ga_id() -> str:
"""Generate a unique GA ID using the ga_id_seq database sequence.
Returns:
diff --git a/gso/workflows/edge_port/create_edge_port.py b/gso/workflows/edge_port/create_edge_port.py
index a3ff763c..a62c7147 100644
--- a/gso/workflows/edge_port/create_edge_port.py
+++ b/gso/workflows/edge_port/create_edge_port.py
@@ -22,7 +22,7 @@ from gso.products.product_types.router import Router
from gso.services.lso_client import LSOState, lso_interaction
from gso.services.netbox_client import NetboxClient
from gso.services.partners import get_partner_by_id
-from gso.services.subscriptions import make_unique_ga_id
+from gso.services.subscriptions import generate_unique_ga_id
from gso.utils.helpers import (
active_pe_router_selector,
available_interfaces_choices,
@@ -150,7 +150,7 @@ def initialize_subscription(
subscription.edge_port.edge_port_name = name
subscription.edge_port.minimum_links = minimum_links
subscription.edge_port.ignore_if_down = ignore_if_down
- ga_id = make_unique_ga_id()
+ ga_id = generate_unique_ga_id()
subscription.edge_port.ga_id = ga_id
subscription.edge_port.mac_address = mac_address
partner_name = get_partner_by_id(partner).name
--
GitLab