From 66ac933a9e75805b14ffb014fa222f169e5ecfc0 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Tue, 30 Apr 2024 12:29:54 +0200
Subject: [PATCH] Update method names in router validation
---
gso/workflows/router/validate_router.py | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gso/workflows/router/validate_router.py b/gso/workflows/router/validate_router.py
index 94d34628..f6b38b03 100644
--- a/gso/workflows/router/validate_router.py
+++ b/gso/workflows/router/validate_router.py
@@ -36,7 +36,7 @@ def verify_ipam_loopback(subscription: Router) -> None:
@step("Verify correct Netbox entry")
-def verify_netbox_entry(subscription: Router) -> None:
+def check_netbox_entry_exists(subscription: Router) -> None:
"""Validate the Netbox entry for a Router.
This will only ensure existence of the node itself in Netbox. Validation of separate interfaces takes places in
@@ -48,7 +48,7 @@ def verify_netbox_entry(subscription: Router) -> None:
@step("Verify correct LibreNMS entry")
-def verify_librenms_entry(subscription: Router) -> None:
+def check_librenms_entry_exists(subscription: Router) -> None:
"""Validate the LibreNMS entry for a Router.
Raises an HTTP error 404 when the device is not present in LibreNMS.
@@ -100,8 +100,8 @@ def validate_router() -> StepList:
>> is_juniper_router(done)
>> unsync
>> verify_ipam_loopback
- >> verify_netbox_entry
- >> verify_librenms_entry
+ >> check_netbox_entry_exists
+ >> check_librenms_entry_exists
>> anonymous_lso_interaction(verify_base_config)
>> anonymous_lso_interaction(validate_ibgp_mesh_config)
>> resync
--
GitLab