From 60355082debe8cbd0e67599c4f2d9223f8bfed58 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Fri, 13 Oct 2023 10:12:59 +0200
Subject: [PATCH] update iptrunk modification unit test
---
.../iptrunk/test_modify_trunk_interface.py | 28 ++++++++++++++-----
1 file changed, 21 insertions(+), 7 deletions(-)
diff --git a/test/workflows/iptrunk/test_modify_trunk_interface.py b/test/workflows/iptrunk/test_modify_trunk_interface.py
index cf6c39a4..4160f954 100644
--- a/test/workflows/iptrunk/test_modify_trunk_interface.py
+++ b/test/workflows/iptrunk/test_modify_trunk_interface.py
@@ -95,10 +95,24 @@ def test_iptrunk_modify_trunk_interface_success(
assert subscription.iptrunk.iptrunk_type == new_type
assert subscription.iptrunk.iptrunk_speed == new_speed
assert subscription.iptrunk.iptrunk_minimum_links == new_link_count
- # FIXME: update assertions below when IPtrunk model is updated
- # assert subscription.iptrunk.iptrunk_sides[0].iptrunk_side_ae_geant_a_sid == new_side_a_sid
- # assert subscription.iptrunk.iptrunk_sides[0].iptrunk_side_ae_members == new_side_a_ae_members
- # assert subscription.iptrunk.iptrunk_sides[0].iptrunk_side_ae_members_description == new_side_a_ae_descriptions
- # assert subscription.iptrunk.iptrunk_sides[1].iptrunk_side_ae_geant_a_sid == new_side_b_sid
- # assert subscription.iptrunk.iptrunk_sides[1].iptrunk_side_ae_members == new_side_b_ae_members
- # assert subscription.iptrunk.iptrunk_sides[1].iptrunk_side_ae_members_description == new_side_b_ae_descriptions
+ assert subscription.iptrunk.iptrunk_sides[0].iptrunk_side_ae_geant_a_sid == new_side_a_sid
+
+ def _find_interface_by_name(interfaces: list[dict[str, str]], name: str):
+ for interface in interfaces:
+ if interface["interface_name"] == name:
+ return interface
+ raise IndexError(f"Interface {name} not found!")
+
+ for member in subscription.iptrunk.iptrunk_sides[0].iptrunk_side_ae_members:
+ assert (
+ member.interface_description
+ == _find_interface_by_name(new_side_a_ae_members, member.interface_name)["interface_description"]
+ )
+
+ assert subscription.iptrunk.iptrunk_sides[1].iptrunk_side_ae_geant_a_sid == new_side_b_sid
+
+ for member in subscription.iptrunk.iptrunk_sides[1].iptrunk_side_ae_members:
+ assert (
+ member.interface_description
+ == _find_interface_by_name(new_side_b_ae_members, member.interface_name)["interface_description"]
+ )
--
GitLab