From 5dd8949c57cc4047f18b577061bd2aba0cc2c98f Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Thu, 1 Aug 2024 16:03:55 +0200
Subject: [PATCH] Update unit tests
---
test/workflows/router/test_create_router.py | 3 ---
test/workflows/router/test_terminate_router.py | 6 ------
2 files changed, 9 deletions(-)
diff --git a/test/workflows/router/test_create_router.py b/test/workflows/router/test_create_router.py
index bb7e7d24..83a2e533 100644
--- a/test/workflows/router/test_create_router.py
+++ b/test/workflows/router/test_create_router.py
@@ -42,9 +42,7 @@ def router_creation_input_form_data(site_subscription_factory, faker):
@patch("gso.workflows.router.create_router.infoblox.find_host_by_fqdn")
@patch("gso.workflows.router.create_router.infoblox.allocate_host")
@patch("gso.workflows.router.create_router.SharePointClient")
-@patch("gso.workflows.router.create_router.KentikClient")
def test_create_nokia_router_success(
- mock_kentik_client,
mock_sharepoint_client,
mock_allocate_host,
mock_find_host_by_fqdn,
@@ -115,7 +113,6 @@ def test_create_nokia_router_success(
assert mock_netbox_create_device.call_count == 1
assert mock_find_host_by_fqdn.call_count == 1
assert mock_sharepoint_client.call_count == 1
- assert mock_kentik_client.call_count == 1
assert "ipam_warning" not in state
diff --git a/test/workflows/router/test_terminate_router.py b/test/workflows/router/test_terminate_router.py
index fe6ebb9c..a41e8b32 100644
--- a/test/workflows/router/test_terminate_router.py
+++ b/test/workflows/router/test_terminate_router.py
@@ -14,9 +14,7 @@ from test.workflows import assert_complete, assert_lso_interaction_success, extr
@patch("gso.workflows.router.terminate_router.NetboxClient.delete_device")
@patch("gso.workflows.router.terminate_router.infoblox.delete_host_by_ip")
@patch("gso.workflows.router.terminate_router.LibreNMSClient.remove_device")
-@patch("gso.workflows.router.terminate_router.KentikClient")
def test_terminate_pe_router_full_success(
- mock_kentik_client,
mock_librenms_remove_device,
mock_delete_host_by_ip,
mock_delete_device,
@@ -56,7 +54,6 @@ def test_terminate_pe_router_full_success(
assert mock_delete_device.call_count == 1
assert mock_delete_host_by_ip.call_count == 1
assert mock_librenms_remove_device.call_count == 1
- assert mock_kentik_client.call_count == 1
assert mock_execute_playbook.call_count == lso_interaction_count
@@ -64,7 +61,6 @@ def test_terminate_pe_router_full_success(
@pytest.mark.parametrize("remove_configuration", [True, False])
@pytest.mark.parametrize("update_ibgp_mesh", [True, False])
@patch("gso.services.lso_client._send_request")
-@patch("gso.workflows.router.terminate_router.KentikClient")
@patch("gso.workflows.router.terminate_router.NetboxClient.delete_device")
@patch("gso.workflows.router.terminate_router.infoblox.delete_host_by_ip")
@patch("gso.workflows.router.terminate_router.LibreNMSClient.remove_device")
@@ -72,7 +68,6 @@ def test_terminate_p_router_full_success(
mock_librenms_remove_device,
mock_delete_host_by_ip,
mock_delete_device,
- mock_kentik_client,
mock_execute_playbook,
remove_configuration,
update_ibgp_mesh,
@@ -109,5 +104,4 @@ def test_terminate_p_router_full_success(
assert mock_delete_device.call_count == 1
assert mock_delete_host_by_ip.call_count == 1
assert mock_librenms_remove_device.call_count == 1
- assert mock_kentik_client.call_count == 1
assert mock_execute_playbook.call_count == lso_interaction_count
--
GitLab