From 5602936fe2fc825a922027a3ec69c86aae10f554 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Tue, 26 Nov 2024 11:56:35 +0100
Subject: [PATCH] Include Provisioning routers by default when calculating an
iBGP mesh
---
gso/utils/helpers.py | 2 +-
gso/workflows/router/validate_router.py | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/gso/utils/helpers.py b/gso/utils/helpers.py
index 53c6aadb..5485bf20 100644
--- a/gso/utils/helpers.py
+++ b/gso/utils/helpers.py
@@ -128,7 +128,7 @@ def generate_inventory_for_routers(
exclude_routers: list[str] | None = None,
router_vendor: Vendor | None = None,
*,
- include_provisioning_routers: bool = False,
+ include_provisioning_routers: bool = True,
) -> dict:
"""Generate an Ansible-compatible inventory for executing playbooks.
diff --git a/gso/workflows/router/validate_router.py b/gso/workflows/router/validate_router.py
index 7927ab66..ae7d29cb 100644
--- a/gso/workflows/router/validate_router.py
+++ b/gso/workflows/router/validate_router.py
@@ -58,9 +58,7 @@ def verify_p_ibgp(subscription: dict[str, Any]) -> LSOState:
extra_vars = {
"dry_run": True,
"subscription": subscription,
- "pe_router_list": generate_inventory_for_routers(RouterRole.PE, include_provisioning_routers=True)["all"][
- "hosts"
- ],
+ "pe_router_list": generate_inventory_for_routers(RouterRole.PE)["all"]["hosts"],
"verb": "verify_p_ibgp",
"is_verification_workflow": "true",
}
--
GitLab