From 3fab6b9c89d8edb525b3e506a9091769404c6447 Mon Sep 17 00:00:00 2001
From: Hakan Calim <hakan.calim@fau.de>
Date: Thu, 30 Nov 2023 20:28:06 +0100
Subject: [PATCH] NAT-329 fixed all nokia side issues with netbox counts ->now
all 4 test works
---
.../workflows/iptrunk/test_modify_trunk_interface.py | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/test/workflows/iptrunk/test_modify_trunk_interface.py b/test/workflows/iptrunk/test_modify_trunk_interface.py
index e7c5d971..5945be94 100644
--- a/test/workflows/iptrunk/test_modify_trunk_interface.py
+++ b/test/workflows/iptrunk/test_modify_trunk_interface.py
@@ -144,10 +144,16 @@ def test_iptrunk_modify_trunk_interface_success(
len(new_side_a_ae_members) if vendor_side_a == RouterVendor.NOKIA else 0) + (
len(new_side_b_ae_members) if vendor_side_b == RouterVendor.NOKIA else 0)
- assert mocked_reserve_interface.call_count == num_ifaces
+ # Define free interfaces for only nokia sides
+ num_free_ifaces = 2 * (vendor_side_a == RouterVendor.NOKIA) + 2 * (vendor_side_b == RouterVendor.NOKIA)
+
+ # lag interface for nokia sides
+ num_lag_ifaces = int(vendor_side_a == RouterVendor.NOKIA) + int(vendor_side_b == RouterVendor.NOKIA)
+
+ assert mocked_reserve_interface.call_count == num_ifaces # Only nokia interfaces per side num is randomly generated
assert mocked_attach_interface_to_lag.call_count == num_ifaces
- assert mocked_free_interface.call_count == 4 # 2 interfaces per side(The old ones)
- assert mocked_detach_interfaces_from_lag.call_count == 2 # 1 time per side
+ assert mocked_free_interface.call_count == num_free_ifaces # 2 interfaces per nokia side(The old ones)
+ assert mocked_detach_interfaces_from_lag.call_count == num_lag_ifaces # 1 time per nokia side
# Assert all subscription properties have been updated correctly
assert subscription.description == f"IP trunk, geant_s_sid:{new_sid}"
--
GitLab