From 2150cca4614a24cfe5657b4d49c994d944dacd83 Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Mon, 29 Apr 2024 14:19:42 +0200
Subject: [PATCH] faker.port_number updated to only generate userspace ports
 (1k-40k)

---
 test/cli/test_imports.py              | 6 +++---
 test/services/test_librenms_client.py | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/cli/test_imports.py b/test/cli/test_imports.py
index 3953804d..73c0d031 100644
--- a/test/cli/test_imports.py
+++ b/test/cli/test_imports.py
@@ -125,7 +125,7 @@ def router_data(temp_file, faker, site_subscription_factory):
         router_data = {
             "router_site": Site.from_subscription(site_subscription_factory()).site.site_name,
             "hostname": str(faker.ipv4()),
-            "ts_port": faker.port_number(),
+            "ts_port": faker.port_number(is_user=True),
             "router_role": RouterRole.PE,
             "router_vendor": Vendor.JUNIPER,
             "router_lo_ipv4_address": mock_ipv4,
@@ -146,7 +146,7 @@ def super_pop_switch_data(temp_file, faker, site_subscription_factory):
         super_pop_switch_data = {
             "hostname": str(faker.ipv4()),
             "super_pop_switch_site": Site.from_subscription(site_subscription_factory()).site.site_name,
-            "super_pop_switch_ts_port": faker.port_number(),
+            "super_pop_switch_ts_port": faker.port_number(is_user=True),
             "super_pop_switch_mgmt_ipv4_address": str(faker.ipv4()),
         }
         super_pop_switch_data.update(**kwargs)
@@ -163,7 +163,7 @@ def office_router_data(temp_file, faker, site_subscription_factory):
         office_router_data = {
             "office_router_fqdn": faker.domain_name(levels=4),
             "office_router_site": Site.from_subscription(site_subscription_factory()).site.site_name,
-            "office_router_ts_port": faker.port_number(),
+            "office_router_ts_port": faker.port_number(is_user=True),
             "office_router_lo_ipv4_address": str(faker.ipv4()),
             "office_router_lo_ipv6_address": str(faker.ipv6()),
         }
diff --git a/test/services/test_librenms_client.py b/test/services/test_librenms_client.py
index 55df5ce1..98afda75 100644
--- a/test/services/test_librenms_client.py
+++ b/test/services/test_librenms_client.py
@@ -31,7 +31,7 @@ def mock_get_device_success(faker):
                     "cryptopass": None,
                     "cryptoalgo": None,
                     "snmpver": "v2c",
-                    "port": faker.port_number(),
+                    "port": faker.port_number(is_user=True),
                     "transport": "udp",
                     "timeout": None,
                     "retries": None,
@@ -118,7 +118,7 @@ def mock_get_device_misconfigured(faker):
                     "cryptopass": None,
                     "cryptoalgo": None,
                     "snmpver": "v2c",
-                    "port": faker.port_number(),
+                    "port": faker.port_number(is_user=True),
                     "transport": "udp",
                     "timeout": None,
                     "retries": None,
-- 
GitLab