From 07ada899c00311fa2530729611ae5d1db6db27dc Mon Sep 17 00:00:00 2001
From: Karel van Klink <karel.vanklink@geant.org>
Date: Thu, 18 Apr 2024 13:39:30 +0200
Subject: [PATCH] Add check for enabled interfaces
---
gso/workflows/iptrunk/validate_iptrunk.py | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/gso/workflows/iptrunk/validate_iptrunk.py b/gso/workflows/iptrunk/validate_iptrunk.py
index ea80bb9c..45e26d3e 100644
--- a/gso/workflows/iptrunk/validate_iptrunk.py
+++ b/gso/workflows/iptrunk/validate_iptrunk.py
@@ -126,6 +126,8 @@ def verify_netbox_entries(subscription: Iptrunk):
f"'{subscription.subscription_id}' but got '{interface.description}'"
)
]
+ if not interface.enabled:
+ netbox_errors += [f"NetBox interface '{side.iptrunk_side_ae_iface}' is not enabled."]
for member in side.iptrunk_side_ae_members:
interface = nbclient.get_interface_by_name_and_device(
member.interface_name, side.iptrunk_side_node.router_fqdn
@@ -137,6 +139,8 @@ def verify_netbox_entries(subscription: Iptrunk):
f"'{subscription.subscription_id}' but got '{interface.description}'"
)
]
+ if not interface.enabled:
+ netbox_errors += [f"NetBox interface '{side.iptrunk_side_ae_iface}' is not enabled."]
if netbox_errors:
raise ProcessFailureError(message="NetBox misconfiguration(s) found", details=str(netbox_errors))
--
GitLab