From 4ba3f6abd03704defa7b1a52874b1f8f49bb1088 Mon Sep 17 00:00:00 2001 From: "ak@geant.org" <ak@geant.org> Date: Fri, 13 Oct 2023 21:46:10 +0100 Subject: [PATCH] fixing linting --- geant/ops_ansible/roles/cic_generic/tasks/fix_template.yaml | 2 +- geant/ops_ansible/roles/cic_generic/tasks/main.yml | 1 - .../ops_ansible/roles/cic_generic/tasks/test_template.yaml | 6 +++--- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/geant/ops_ansible/roles/cic_generic/tasks/fix_template.yaml b/geant/ops_ansible/roles/cic_generic/tasks/fix_template.yaml index bb71812..dbe13be 100644 --- a/geant/ops_ansible/roles/cic_generic/tasks/fix_template.yaml +++ b/geant/ops_ansible/roles/cic_generic/tasks/fix_template.yaml @@ -14,5 +14,5 @@ - name: Show diff of "{{ config_object }}" ansible.builtin.debug: msg: "{{ response }}" - when: verb == "fix" and not (dry_run | ansible.builtin.bool) + when: verb == "fix" and not (dry_run | ansible.builtin.bool) diff --git a/geant/ops_ansible/roles/cic_generic/tasks/main.yml b/geant/ops_ansible/roles/cic_generic/tasks/main.yml index e2c2746..746776e 100644 --- a/geant/ops_ansible/roles/cic_generic/tasks/main.yml +++ b/geant/ops_ansible/roles/cic_generic/tasks/main.yml @@ -56,4 +56,3 @@ - name: Include the test tasks if specified include_tasks: fix_template.yaml when: verb == "fix" - diff --git a/geant/ops_ansible/roles/cic_generic/tasks/test_template.yaml b/geant/ops_ansible/roles/cic_generic/tasks/test_template.yaml index 0db0e76..51173d8 100644 --- a/geant/ops_ansible/roles/cic_generic/tasks/test_template.yaml +++ b/geant/ops_ansible/roles/cic_generic/tasks/test_template.yaml @@ -11,7 +11,7 @@ register: response when: verb == "test" and dry_run | ansible.builtin.bool -### This task never fails. It only shows differences if ther are any +### This task never fails. It only shows differences if ther are any ### but commit-check in the previous task should succeed - name: Show DRY diff of "{{ config_object }}" ansible.builtin.debug: @@ -22,7 +22,7 @@ # - name: Fail if there are diffs # ansible.builtin.fail: # msg: "Running configuration is not the same as the intended" -# when: response.changed == true +# when: response.changed == true - name: Send an e-mail using Geant SMTP servers mail: @@ -30,7 +30,7 @@ port: "{{ cic_alerts_smtp_port }}" sender: "{{ cic_alerts_sender }}" to: "{{ cic_alerts_recipient }}" - subject: "Config Integrity Check failed for {{ inventory_hostname }} on {{ config_object }}" + subject: "Config Integrity Check failed for {{ inventory_hostname }} on {{ config_object }}" body: "{{ lookup('ansible.builtin.template', 'mail_body.j2') }}" delegate_to: localhost when: response.changed == true and (send_email | ansible.builtin.bool) == true -- GitLab