From f967e4aa239ea63b641d484a64d5790f05cfe450 Mon Sep 17 00:00:00 2001
From: "alexander.lovett" <alexander.lovett@geant.org>
Date: Tue, 3 Mar 2020 14:03:22 +0000
Subject: [PATCH] Sonar fixes.
---
.../security/LGAuthenticationSuccessHandler.java | 5 +++--
.../LookingGlassServiceApplicationTests.java | 16 ----------------
2 files changed, 3 insertions(+), 18 deletions(-)
delete mode 100644 src/test/java/org/geant/lgservice/LookingGlassServiceApplicationTests.java
diff --git a/src/main/java/org/geant/lgservice/security/LGAuthenticationSuccessHandler.java b/src/main/java/org/geant/lgservice/security/LGAuthenticationSuccessHandler.java
index 274544c..08bdb9d 100644
--- a/src/main/java/org/geant/lgservice/security/LGAuthenticationSuccessHandler.java
+++ b/src/main/java/org/geant/lgservice/security/LGAuthenticationSuccessHandler.java
@@ -6,6 +6,7 @@ import javax.servlet.ServletException;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
+import lombok.extern.slf4j.Slf4j;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.springframework.security.core.Authentication;
@@ -13,13 +14,13 @@ import org.springframework.security.web.authentication.SavedRequestAwareAuthenti
import org.springframework.stereotype.Component;
@Component
+@Slf4j
public class LGAuthenticationSuccessHandler extends SavedRequestAwareAuthenticationSuccessHandler {
- private static final Logger LOGGER = LogManager.getLogger(LGAuthenticationSuccessHandler.class);
@Override
public void onAuthenticationSuccess(HttpServletRequest request, HttpServletResponse response, Authentication auth)
throws IOException, ServletException {
- LOGGER.info("Authentication success");
+ log.info("Authentication success");
getRedirectStrategy().sendRedirect(request, response, "/");
}
diff --git a/src/test/java/org/geant/lgservice/LookingGlassServiceApplicationTests.java b/src/test/java/org/geant/lgservice/LookingGlassServiceApplicationTests.java
deleted file mode 100644
index 6f1a6e5..0000000
--- a/src/test/java/org/geant/lgservice/LookingGlassServiceApplicationTests.java
+++ /dev/null
@@ -1,16 +0,0 @@
-package org.geant.lgservice;
-
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.springframework.boot.test.context.SpringBootTest;
-import org.springframework.test.context.junit4.SpringRunner;
-
-@RunWith(SpringRunner.class)
-@SpringBootTest
-public class LookingGlassServiceApplicationTests {
-
- @Test
- public void contextLoads() {
- }
-
-}
--
GitLab