From dfbc6fad6728396efcd0e32d1dee05a283005875 Mon Sep 17 00:00:00 2001
From: "saket.agrahari" <saket.agrahari@geant.org>
Date: Fri, 17 Jun 2022 15:30:32 +0100
Subject: [PATCH] correcting the test case scenario

---
 inventory_provider/db/ims_data.py | 6 +++---
 test/test_ims_data.py             | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/inventory_provider/db/ims_data.py b/inventory_provider/db/ims_data.py
index 7e9b332b..df9026d1 100644
--- a/inventory_provider/db/ims_data.py
+++ b/inventory_provider/db/ims_data.py
@@ -388,7 +388,7 @@ def get_node_locations(ds: IMS):
             pass  # no alias - ignore silently
 
         for node in site['nodes']:
-            if node['inventorystatusid'] in STATUSES_TO_IGNORE:
+            if node['inventorystatusid'] != InventoryStatus.IN_SERVICE.value:
                 continue
 
             yield (node['name'], {
@@ -439,7 +439,7 @@ def lookup_lg_routers(ds: IMS):
     def _matching_node(node_):
         # [LG-46]
         if InventoryStatus(node_['inventorystatusid']) \
-                != InventoryStatus.IN_SERVICE.value:
+                != InventoryStatus.IN_SERVICE:
             return False
 
         if pattern.match(node_['name']):
@@ -464,7 +464,7 @@ def lookup_lg_routers(ds: IMS):
         for node in nodes:
             if not _matching_node(node):
                 continue
-            if node['inventorystatusid'] in STATUSES_TO_IGNORE:
+            if node['inventorystatusid'] != InventoryStatus.IN_SERVICE.value:
                 continue
 
             site = ds.get_entity_by_id('Site', node['siteid'], site_nav_props,
diff --git a/test/test_ims_data.py b/test/test_ims_data.py
index 69d0737a..2a12e0db 100644
--- a/test/test_ims_data.py
+++ b/test/test_ims_data.py
@@ -266,8 +266,8 @@ def test_lookup_lg_routers(mocker):
         'Name like MX',
         inventory_provider.db.ims.EQUIP_DEF_PROPERTIES['Nodes'])
 
-    assert ds.get_entity_by_id.call_count == 36
-    assert len(res) == 36
+    assert ds.get_entity_by_id.call_count == 35
+    assert len(res) == 35
 
     pop = {
         'name': 'pop name',
-- 
GitLab