diff --git a/inventory_provider/db/ims_data.py b/inventory_provider/db/ims_data.py index 7e9b332b6a23e8fa50cc43ba5ffe9b550940e34c..df9026d17f54572d9bbc11d24fa3821e7e8e9fe6 100644 --- a/inventory_provider/db/ims_data.py +++ b/inventory_provider/db/ims_data.py @@ -388,7 +388,7 @@ def get_node_locations(ds: IMS): pass # no alias - ignore silently for node in site['nodes']: - if node['inventorystatusid'] in STATUSES_TO_IGNORE: + if node['inventorystatusid'] != InventoryStatus.IN_SERVICE.value: continue yield (node['name'], { @@ -439,7 +439,7 @@ def lookup_lg_routers(ds: IMS): def _matching_node(node_): # [LG-46] if InventoryStatus(node_['inventorystatusid']) \ - != InventoryStatus.IN_SERVICE.value: + != InventoryStatus.IN_SERVICE: return False if pattern.match(node_['name']): @@ -464,7 +464,7 @@ def lookup_lg_routers(ds: IMS): for node in nodes: if not _matching_node(node): continue - if node['inventorystatusid'] in STATUSES_TO_IGNORE: + if node['inventorystatusid'] != InventoryStatus.IN_SERVICE.value: continue site = ds.get_entity_by_id('Site', node['siteid'], site_nav_props, diff --git a/test/test_ims_data.py b/test/test_ims_data.py index 69d0737a03191c9f3466b86241a8401964605db8..2a12e0dbb09163b22e805ac2cac7b56111c825ea 100644 --- a/test/test_ims_data.py +++ b/test/test_ims_data.py @@ -266,8 +266,8 @@ def test_lookup_lg_routers(mocker): 'Name like MX', inventory_provider.db.ims.EQUIP_DEF_PROPERTIES['Nodes']) - assert ds.get_entity_by_id.call_count == 36 - assert len(res) == 36 + assert ds.get_entity_by_id.call_count == 35 + assert len(res) == 35 pop = { 'name': 'pop name',