From c42050b77a3cc7c809cead9e07f1c6994614f89c Mon Sep 17 00:00:00 2001
From: Samuel Roberts <sam.roberts@geant.org>
Date: Wed, 9 Aug 2023 10:14:09 +0100
Subject: [PATCH] MR review changes
---
inventory_provider/juniper.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/inventory_provider/juniper.py b/inventory_provider/juniper.py
index 1e745e42..b71452b8 100644
--- a/inventory_provider/juniper.py
+++ b/inventory_provider/juniper.py
@@ -274,7 +274,6 @@ def list_interfaces(netconf_config):
if _inactive(i):
continue
info = _ifc_info(i)
- # TODO: ADD SPEED VALUE TO INFO HERE
yield info
yield from _units(info['name'], i)
@@ -486,7 +485,8 @@ def get_interface_speeds(interface_info):
if len(name) > 0:
name = name[0].text.strip()
else:
- name = "NO_NAME_FOUND"
+ logger = logging.getLogger(__name__)
+ logger.warning('no name entries for interface')
speed = physical_interface.xpath("./*[local-name() = 'speed']")
if len(speed) > 0:
speed = speed[0].text.strip()
--
GitLab