From 99a3013c30ae5514dca1aca8292998605a98e4e0 Mon Sep 17 00:00:00 2001
From: Erik Reid <erik.reid@geant.org>
Date: Wed, 11 Mar 2020 13:10:09 +0100
Subject: [PATCH] use local rather than global var
---
inventory_provider/juniper.py | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/inventory_provider/juniper.py b/inventory_provider/juniper.py
index 7cda57d2..7b21dc93 100644
--- a/inventory_provider/juniper.py
+++ b/inventory_provider/juniper.py
@@ -386,13 +386,12 @@ def load_routers_from_junosspace(config):
def _derive_hostname(n):
# TODO: ask ops if this name->hostname operation is valid
- if name.endswith('geant.net'):
- return name
- m = re.match(r'^(.*?)(\.re\d+)?$', name)
+ if n.endswith('geant.net'):
+ return n
+ m = re.match(r'^(.*?)(\.re\d+)?$', n)
if m:
return m.group(1) + '.geant.net'
- logger.error(
- 'unrecognized junosspace device name format :%s' % name)
+ logger.error(f'unrecognized junosspace device name format: "{n}"')
return None
for d in devices.xpath('//devices/device'):
--
GitLab