diff --git a/inventory_provider/juniper.py b/inventory_provider/juniper.py index 7cda57d27c9cf9f6807a559de12c40771ebc73ff..7b21dc93ddc058b665f8e8a51c48b0dae57c839e 100644 --- a/inventory_provider/juniper.py +++ b/inventory_provider/juniper.py @@ -386,13 +386,12 @@ def load_routers_from_junosspace(config): def _derive_hostname(n): # TODO: ask ops if this name->hostname operation is valid - if name.endswith('geant.net'): - return name - m = re.match(r'^(.*?)(\.re\d+)?$', name) + if n.endswith('geant.net'): + return n + m = re.match(r'^(.*?)(\.re\d+)?$', n) if m: return m.group(1) + '.geant.net' - logger.error( - 'unrecognized junosspace device name format :%s' % name) + logger.error(f'unrecognized junosspace device name format: "{n}"') return None for d in devices.xpath('//devices/device'):