From 734eb0c84312d65f8dc480f401db7c3226522f1a Mon Sep 17 00:00:00 2001 From: Erik Reid <erik.reid@geant.org> Date: Tue, 16 Feb 2021 13:09:44 +0100 Subject: [PATCH] pep8 & typos --- inventory_provider/routes/msr.py | 9 ++++----- test/test_msr_routes.py | 4 ++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/inventory_provider/routes/msr.py b/inventory_provider/routes/msr.py index d1f24c34..f4c03200 100644 --- a/inventory_provider/routes/msr.py +++ b/inventory_provider/routes/msr.py @@ -157,7 +157,6 @@ def _handle_peering_group_request(name, cache_key, group_key_base): if value: yield from json.loads(value.decode('utf-8')) - if name: cache_key = f'{cache_key}:{name}' @@ -196,7 +195,7 @@ def logical_system_peerings(name=None): logical system if no parameter is given. :return: see :meth:`inventory_provider.routes.msr._handle_peering_group_request` - """ + """ # noqa: E501 return _handle_peering_group_request( name=name, cache_key='classifier-cache:msr:logical-system-peerings', @@ -215,7 +214,7 @@ def bgp_group_peerings(name=None): logical system if no parameter is given. :return: see :meth:`inventory_provider.routes.msr._handle_peering_group_request` - """ + """ # noqa: E501 return _handle_peering_group_request( name=name, cache_key='classifier-cache:msr:group-peerings', @@ -276,7 +275,7 @@ def get_logical_systems(): information is available. :return: see :meth:`inventory_provider.routes.msr._handle_peering_group_list_request` - """ + """ # noqa: E501 return _handle_peering_group_list_request( cache_key='classifier-cache:msr:logical-systems', group_key_base='juniper-peerings:logical-system') @@ -292,7 +291,7 @@ def get_peering_groups(): information is available. :return: see :meth:`inventory_provider.routes.msr._handle_peering_group_list_request` - """ + """ # noqa: E501 return _handle_peering_group_list_request( cache_key='classifier-cache:msr:peering-groups', group_key_base='juniper-peerings:group') diff --git a/test/test_msr_routes.py b/test/test_msr_routes.py index 1a4ce292..173cf152 100644 --- a/test/test_msr_routes.py +++ b/test/test_msr_routes.py @@ -67,7 +67,7 @@ def test_logical_system_peerings_404(client, name): def test_group_peerings_all(client): rv = client.get( - f'/msr/bgp/group-peerings', + '/msr/bgp/group-peerings', headers=DEFAULT_REQUEST_HEADERS) assert rv.status_code == 200 assert rv.is_json @@ -92,7 +92,7 @@ def test_group_peerings_specific(client, name): @pytest.mark.parametrize('name', ['EGEANT', 'eGEANT mcast']) -def test_logical_system_peerings_404(client, name): +def test_group_peerings_404(client, name): rv = client.get( f'/msr/bgp/logical-system-peerings/{name}', headers=DEFAULT_REQUEST_HEADERS) -- GitLab