From 6cf2620fb4669faf7d78bdfcde373b732ed4c58b Mon Sep 17 00:00:00 2001
From: Erik Reid <erik.reid@geant.org>
Date: Thu, 17 Feb 2022 11:15:45 +0100
Subject: [PATCH] add failure message and more logging in case of unhandled
 router load errors

---
 inventory_provider/tasks/worker.py | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/inventory_provider/tasks/worker.py b/inventory_provider/tasks/worker.py
index 4d2ee9db..098fb57f 100644
--- a/inventory_provider/tasks/worker.py
+++ b/inventory_provider/tasks/worker.py
@@ -563,8 +563,10 @@ def reload_lab_router_config_chorded(self, hostname):
 
         self.log_info(f'updated configuration for lab {hostname}')
     except Exception as e:
-        logger.error(e)
+        errmsg = f'unhandled exception loading {hostname} info'
+        logger.exception(errmsg)
         update_latch_status(InventoryTask.config, pending=True, failure=True)
+        self.log_error(errmsg)
 
 
 @app.task(base=InventoryTask, bind=True, name='reload_router_config')
@@ -598,9 +600,11 @@ def reload_router_config_chorded(self, hostname):
             snmp_refresh_peerings_chorded(hostname, community, logical_systems)
 
         logger.info(f'updated configuration for {hostname}')
-    except Exception as e:
-        logger.error(e)
+    except:
+        errmsg = f'unhandled exception loading {hostname} info'
+        logger.exception(errmsg)
         update_latch_status(InventoryTask.config, pending=True, failure=True)
+        self.log_error(errmsg)
 
 
 def retrieve_and_persist_netconf_config(
-- 
GitLab