From 655808bded1402b52d129966cf4e3d42bb2c36b4 Mon Sep 17 00:00:00 2001 From: Robert Latta <robert.latta@geant.org> Date: Wed, 20 Nov 2019 11:06:25 +0000 Subject: [PATCH] moved all_rs list and return out of for loop to ensure all related services are added before returning --- inventory_provider/routes/classifier.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inventory_provider/routes/classifier.py b/inventory_provider/routes/classifier.py index e5576d48..b6d83118 100644 --- a/inventory_provider/routes/classifier.py +++ b/inventory_provider/routes/classifier.py @@ -110,10 +110,10 @@ def get_juniper_link_info(source_equipment, interface): } def _related_services(): + all_rs = [] for related in related_interfaces(source_equipment, interface): rs = r.get('opsdb:interface_services:%s:%s' % (source_equipment, related)) - all_rs = [] if rs: for s in json.loads(rs.decode('utf-8')): top_level_services.extend( @@ -124,7 +124,7 @@ def get_juniper_link_info(source_equipment, interface): 'status': s['status'], 'circuit_type': s['circuit_type'] }) - return all_rs + return all_rs related_services = _related_services() if related_services: -- GitLab