From 4d51292f3445a7dbe353f693c30774cff0b8ca3d Mon Sep 17 00:00:00 2001
From: Erik Reid <erik.reid@geant.org>
Date: Wed, 23 Sep 2020 12:07:16 +0200
Subject: [PATCH] return dummy location data for unknown routers

---
 inventory_provider/routes/classifier.py | 25 ++++++++++++-------------
 1 file changed, 12 insertions(+), 13 deletions(-)

diff --git a/inventory_provider/routes/classifier.py b/inventory_provider/routes/classifier.py
index 15b54765..2d082836 100644
--- a/inventory_provider/routes/classifier.py
+++ b/inventory_provider/routes/classifier.py
@@ -38,24 +38,23 @@ def _location_from_router(router_name):
     result = r.get(f'opsdb:location:{router_name}')
     if not result:
         logger.error(f'error looking up location for {router_name}')
-        return None
-        # return {
-        #     'a': _LOCATION(
-        #         equipment=router_name,
-        #         name='?',
-        #         abbreviation='?')
-        # }
+        return {
+            'a': _LOCATION(
+                equipment=router_name,
+                name='?',
+                abbreviation='?')
+        }
 
     result = json.loads(result.decode('utf-8'))
     if not result:
         logger.error(f'sanity failure: empty list for location {router_name}')
         return None
-        # return {
-        #     'a': _LOCATION(
-        #         equipment=router_name,
-        #         name='?',
-        #         abbreviation='?')
-        # }
+        return {
+            'a': _LOCATION(
+                equipment=router_name,
+                name='?',
+                abbreviation='?')
+        }
 
     return {
         'a': _LOCATION(
-- 
GitLab