From 6e8812aa63670ff8a11d872f1867e25c0acd966b Mon Sep 17 00:00:00 2001
From: Remco Tukker <remco.tukker@geant.org>
Date: Fri, 18 Aug 2023 15:24:22 +0200
Subject: [PATCH] add testcase

---
 compendium_v2/conversion/conversion.py |  1 +
 test/test_conversion.py                | 18 +++++++++++++++++-
 2 files changed, 18 insertions(+), 1 deletion(-)

diff --git a/compendium_v2/conversion/conversion.py b/compendium_v2/conversion/conversion.py
index 78ab3664..9c0e9f91 100644
--- a/compendium_v2/conversion/conversion.py
+++ b/compendium_v2/conversion/conversion.py
@@ -5,6 +5,7 @@ conversion
 This module loads the survey data from 2022 from the survey database
 and stores the data in the json structure of the new survey, so that
 it can be used to prefill the 2023 survey.
+It also loads an xlsx file with the data for the services questions.
 
 """
 import logging
diff --git a/test/test_conversion.py b/test/test_conversion.py
index eee67c3f..0f480505 100644
--- a/test/test_conversion.py
+++ b/test/test_conversion.py
@@ -4,7 +4,7 @@ from sqlalchemy.orm import lazyload
 from compendium_v2.db import db
 from compendium_v2.db.model import NREN
 from compendium_v2.db.survey_model import Survey, SurveyResponse, SurveyStatus
-from compendium_v2.conversion.conversion import _cli, convert_answers
+from compendium_v2.conversion.conversion import _cli, convert_answers, load_service_data
 
 
 def mock_convert_answers(_):
@@ -72,3 +72,19 @@ def test_conversion():
             }
         }
     }
+
+
+def test_load_service_data():
+    service_data_dict = load_service_data()
+    assert len(service_data_dict.keys()) == 42
+    assert len(service_data_dict['ARNES'].keys()) == 8
+    assert len(service_data_dict['ARNES']['services_identity']) == 3
+    assert len(service_data_dict['SURF'].keys()) == 7
+    assert len(service_data_dict['SURF']['services_network']) == 10
+    assert service_data_dict['SURF']['services_security']['security-audit'] == {
+        'offered': ['yes'],
+        'name': 'SURFaudit',
+        'additional_information': 'The Standard for Information Security in Higher Education is the basis of '
+                                  'SURFaudit’s self-assessment.\n\nSURFaudit Security Standard for Higher '
+                                  'Education is derived from the ISO/IEC 27002:2013 standard'
+    }
-- 
GitLab