From b91fa901a9366fd162866354a3d8efc08bc07ca2 Mon Sep 17 00:00:00 2001
From: Erik Reid <erik.reid@geant.org>
Date: Mon, 11 Oct 2021 09:54:30 +0200
Subject: [PATCH] don't use dict.default without default value
---
brian_dashboard_manager/grafana/provision.py | 2 +-
test/test_update.py | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/brian_dashboard_manager/grafana/provision.py b/brian_dashboard_manager/grafana/provision.py
index ce99f75..053fb7c 100644
--- a/brian_dashboard_manager/grafana/provision.py
+++ b/brian_dashboard_manager/grafana/provision.py
@@ -585,7 +585,7 @@ def provision(config):
dashboard = dashboard.result()
if dashboard is None:
continue
- managed_dashboard_uids.add(dashboard.get('uid'))
+ managed_dashboard_uids.add(dashboard['uid'])
for uid in all_original_dashboard_uids - managed_dashboard_uids:
logger.info(f'Deleting stale dashboard with UID {uid}')
diff --git a/test/test_update.py b/test/test_update.py
index f12d2c6..94600c1 100644
--- a/test/test_update.py
+++ b/test/test_update.py
@@ -653,7 +653,7 @@ def test_provision(data_config, mocker, client):
responses.add(
method=responses.POST,
url=f"http://{data_config['hostname']}/api/dashboards/db",
- json={'id': 666})
+ json={'uid': '999', 'id': 666})
responses.add(
method=responses.PUT,
@@ -726,7 +726,7 @@ def test_provision(data_config, mocker, client):
'brian_dashboard_manager.grafana.provision.create_dashboard')
# we dont care about this, just mark it created
# we dont care about this, tested separately
- _mocked_create_dashboard.return_value = {'id': 666}
+ _mocked_create_dashboard.return_value = {'uid': '999', 'id': 666}
_mocked_delete_api_token = mocker.patch(
'brian_dashboard_manager.grafana.provision.delete_api_token')
--
GitLab