diff --git a/README.md b/README.md index f46db6dbfba71bdca01b6abad1c6ca92b2d9f398..9f91d86fab180766181411886af037d89fc009f2 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # A tool to manage certificates lifecycle on Vault, Redis, Consul - + ## Install the package diff --git a/wile_coyote/bin/cert2json b/wile_coyote/bin/cert2json index 7a8c61494bfd4506f5b766643b3223f2faceb554..b3222e58678500c639d768d77baa723016649c0c 100755 --- a/wile_coyote/bin/cert2json +++ b/wile_coyote/bin/cert2json @@ -38,8 +38,9 @@ else: def inspect_certificate(cert): - """ extract data from certificate """ - pem_data = open(os.path.join(cert, 'fullchain.pem'), "rb").read() + """ extract data from the certificate """ + with open(os.path.join(cert, 'fullchain.pem'), "rb") as pem_file: + pem_data = pem_file.read() cert = x509.load_pem_x509_certificate(pem_data, default_backend()) cert_name = cert.subject.get_attributes_for_oid(x509.OID_COMMON_NAME)[0].value.strip() serial_raw = f'{cert.serial_number:x}'.upper()