From 41ea869aaa30d83e60981d65285cf416be469c14 Mon Sep 17 00:00:00 2001
From: Guillaume Rousse <guillaume.rousse@renater.fr>
Date: Fri, 3 Nov 2017 14:01:03 +0100
Subject: [PATCH] prefer Data::Dumper over custom code
---
bin/account-manager-client.pl | 4 ++--
lib/IdPAccountManager/Tools.pm | 31 -------------------------------
2 files changed, 2 insertions(+), 33 deletions(-)
diff --git a/bin/account-manager-client.pl b/bin/account-manager-client.pl
index 08d1ecc..84dd2ad 100755
--- a/bin/account-manager-client.pl
+++ b/bin/account-manager-client.pl
@@ -7,6 +7,7 @@ use lib qw(lib);
use feature "switch";
no warnings 'experimental::smartmatch';
+use Data::Dumper;
use English qw(-no_match_vars);
use Getopt::Long qw(:config auto_help);
use Pod::Usage;
@@ -171,8 +172,7 @@ sub parse_federation_metadata {
## List SAML entities
printf "Hashref representing the metadata:\n";
- IdPAccountManager::Tools::dump_var($data, 0, \*STDOUT);
-
+ print Data::Dumper->Dump($data);
}
sub add_service_provider {
diff --git a/lib/IdPAccountManager/Tools.pm b/lib/IdPAccountManager/Tools.pm
index ffca2c4..7d1dcf6 100644
--- a/lib/IdPAccountManager/Tools.pm
+++ b/lib/IdPAccountManager/Tools.pm
@@ -100,37 +100,6 @@ sub update_ssp_authsources {
}
-## Dump a variable's content
-sub dump_var {
- my ($var, $level, $fd) = @_;
-
- if (ref($var)) {
- if (ref($var) eq 'ARRAY') {
- foreach my $index (0 .. $#{$var}) {
- print $fd "\t" x $level . $index . "\n";
- dump_var($var->[$index], $level + 1, $fd);
- }
- } elsif (ref($var) eq 'HASH') {
- foreach my $key (sort keys %{$var}) {
- print $fd "\t" x $level . '_' . $key . '_' . "\n";
- dump_var($var->{$key}, $level + 1, $fd);
- }
- } else {
- if (defined $var) {
- print $fd "\t" x $level . "'$var'" . "\n";
- } else {
- print $fd "\t" x $level . "UNDEF\n";
- }
- }
- } else {
- if (defined $var) {
- print $fd "\t" x $level . "'$var'" . "\n";
- } else {
- print $fd "\t" x $level . "UNDEF\n";
- }
- }
-}
-
## Send a mail notice
## Default is to send email to the manager admins, unless other recipients are specified
## mail_notice(IN)
--
GitLab