From 3835bef7f7dc4501d004cdcd6467708849e2f214 Mon Sep 17 00:00:00 2001
From: Guillaume Rousse <guillaume.rousse@renater.fr>
Date: Thu, 2 Nov 2017 11:45:37 +0100
Subject: [PATCH] drop useless return value

---
 lib/IdPAccountManager/AuthenticationToken.pm | 4 ----
 lib/IdPAccountManager/SAMLMetadata.pm        | 2 --
 lib/IdPAccountManager/ServiceProvider.pm     | 2 --
 lib/IdPAccountManager/TestAccount.pm         | 2 --
 4 files changed, 10 deletions(-)

diff --git a/lib/IdPAccountManager/AuthenticationToken.pm b/lib/IdPAccountManager/AuthenticationToken.pm
index 8155904..8d03e73 100644
--- a/lib/IdPAccountManager/AuthenticationToken.pm
+++ b/lib/IdPAccountManager/AuthenticationToken.pm
@@ -60,8 +60,6 @@ sub set {
     foreach my $parameter (keys %args) {
         $self->{'persistent'}->$parameter($args{$parameter});
     }
-
-    return 1;
 }
 
 ## Save object to DB
@@ -99,8 +97,6 @@ sub print {
       $self->get('id'), $self->get('token'), $self->get('email_address'),
       $self->get('sp_entityid'),
       POSIX::strftime('%Y:%m:%d', localtime($self->get('creation_date')));
-
-    return 1.;
 }
 
 ## list all authentication tokens
diff --git a/lib/IdPAccountManager/SAMLMetadata.pm b/lib/IdPAccountManager/SAMLMetadata.pm
index db8e00b..e605115 100644
--- a/lib/IdPAccountManager/SAMLMetadata.pm
+++ b/lib/IdPAccountManager/SAMLMetadata.pm
@@ -107,8 +107,6 @@ sub print {
 
     my $root = $self->{'federation_metadata_as_xml'}->documentElement();
     print $fd $root->toString();
-
-    return 1.;
 }
 
 ## returns a Lib::XML représenting an XML file
diff --git a/lib/IdPAccountManager/ServiceProvider.pm b/lib/IdPAccountManager/ServiceProvider.pm
index 21f8e92..f773674 100644
--- a/lib/IdPAccountManager/ServiceProvider.pm
+++ b/lib/IdPAccountManager/ServiceProvider.pm
@@ -30,8 +30,6 @@ sub print {
     printf $fd
       "ServiceProvider ID=%s; entityid=%s; displayname=%s; contacts=%s\n",
       $self->id, $self->entityid, $self->displayname, $self->contacts;
-
-    return 1.;
 }
 
 ## list contacts for this SP, including those listed in conf.dev_sp_contact
diff --git a/lib/IdPAccountManager/TestAccount.pm b/lib/IdPAccountManager/TestAccount.pm
index 9406302..ffa9633 100644
--- a/lib/IdPAccountManager/TestAccount.pm
+++ b/lib/IdPAccountManager/TestAccount.pm
@@ -91,8 +91,6 @@ sub print {
       $self->get('sp_entityid'), $self->get('account_profile'),
       POSIX::strftime('%Y:%m:%d', localtime($self->get('creation_date'))),
       POSIX::strftime('%Y:%m:%d', localtime($self->get('expiration_date')));
-
-    return 1.;
 }
 
 ## list all test accounts
-- 
GitLab